turso icon indicating copy to clipboard operation
turso copied to clipboard

Minimal cargo-c support

Open lu-zero opened this issue 1 year ago • 2 comments

Fixes #437

lu-zero avatar Dec 12 '24 20:12 lu-zero

Looks like something broke with the C library build:

LIBS="../.././target/debug/liblimbo_sqlite3.a" make -C sqlite3/tests test
make[1]: Entering directory '/home/runner/work/limbo/limbo/sqlite3/tests'
  CC       main.o
  CC       test-aux.o
  CC       test-close.o
  CC       test-open.o
  CC       test-prepare.o
  LINK     sqlite3-tests
/usr/bin/ld: cannot find ../.././target/debug/liblimbo_sqlite3.a: No such file or directory
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:36: sqlite3-tests] Error 1
make[1]: Leaving directory '/home/runner/work/limbo/limbo/sqlite3/tests'
make: *** [Makefile:63: test-sqlite3] Error 2

penberg avatar Dec 13 '24 09:12 penberg

I didn't port the tests yet, cargo-c has a mean to run C-tests on its own or if you want to preserve the Makefile you may use the uninstalled pkg-config it produces.

lu-zero avatar Dec 13 '24 09:12 lu-zero

@lu-zero I think we need to preserve the Makefile because you want to be able to run the same tests with both Limbo and SQLite?

penberg avatar Dec 14 '24 09:12 penberg

Sure, I can expand it to use pkg-config if you deem it useful.

lu-zero avatar Dec 14 '24 13:12 lu-zero