turso icon indicating copy to clipboard operation
turso copied to clipboard
Published 4 months ago • verified publisher icon tursodatabase

Adds AddImm OpCode Instruction

Open redixhumayun opened this issue 1 year ago • 5 comments

This PR:

  • adds the AddImm opcode instruction

The instruction is required for https://github.com/tursodatabase/limbo/issues/895 which is tracking ALTER TABLE support.

See screenshot for relevant SQLite bytecode

Screenshot 2025-02-19 at 10 12 16 PM

redixhumayun avatar Feb 19 '25 16:02 redixhumayun

Hey @redixhumayun, I folded Value into OwnedValue and caused a merge conflict here. Can you please rebase?

penberg avatar Feb 26 '25 11:02 penberg

Hey @redixhumayun, I folded Value into OwnedValue and caused a merge conflict here. Can you please rebase?

@penberg Hey, just saw this and took care of it. The conflict is resolved.

There are a few tests failing but I think that has to do with the fuzzer? Unsure because I don't think that has anything to do with my changes.

redixhumayun avatar Mar 06 '25 11:03 redixhumayun

This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

penberg avatar Apr 06 '25 00:04 penberg

@penberg can we merge this in?

redixhumayun avatar Apr 10 '25 13:04 redixhumayun

This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

penberg avatar May 12 '25 00:05 penberg

This pull request has been closed due to inactivity. Please feel free to reopen it if you have further updates.

penberg avatar May 19 '25 00:05 penberg