libsql icon indicating copy to clipboard operation
libsql copied to clipboard

Fix a windows incompatibility in connection.rs libsql-sys.

Open milen-denev opened this issue 1 year ago • 3 comments

image

image

        #[cfg(not(target_os = "windows"))]
        use std::os::unix::ffi::OsStrExt;

        #[cfg(target_os = "windows")]
        use std::os::windows::ffi::OsStrExt;

        #[cfg(not(feature = "rusqlite"))]
        let conn = unsafe {

            #[cfg(target_os = "windows")]
            let path = std::ffi::CString::new(path.as_ref().as_os_str().as_encoded_bytes())
                .map_err(|_| crate::error::Error::Bug("invalid database path"))?;

            #[cfg(not(target_os = "windows"))]
            let path = std::ffi::CString::new(path.as_ref().as_os_str().as_bytes())
                .map_err(|_| crate::error::Error::Bug("invalid database path"))?;

milen-denev avatar Nov 08 '24 13:11 milen-denev

needs rustfmt for CI to pass

LucioFranco avatar Nov 14 '24 19:11 LucioFranco

needs rustfmt for CI to pass

I am sorry, I am very new to commiting, what should I do? Run rustfmt and re-submit a pull request?

milen-denev avatar Nov 15 '24 12:11 milen-denev

You can run cargo fmt it should do the trick

LucioFranco avatar Nov 18 '24 16:11 LucioFranco

This pull request has not been updated for months so closing as stale.

penberg avatar Mar 20 '25 10:03 penberg