kysely-libsql icon indicating copy to clipboard operation
kysely-libsql copied to clipboard

use @libsql/client instead of @libsql/hrana-client

Open ottomated opened this issue 1 year ago • 2 comments

This repo still uses the internal @libsql/hrana-client library. This PR updates it to use @libsql/client for parity.

ottomated avatar Apr 17 '24 19:04 ottomated

This is a very impactful change as we are using Kysely for our ORM, and having access to the full set of @libsql/client features (e.g. embedded replicas) would be a big win. cc @penberg

jkonowitch avatar May 16 '24 16:05 jkonowitch

@jkonowitch I've got a fork up at @ottomated/kysely-libsql if you want to use that in the meantime. You'll also need to apply this patch: https://github.com/libsql/hrana-client-ts/pull/14

ottomated avatar May 16 '24 17:05 ottomated

Depends on https://github.com/tursodatabase/libsql-client-ts/pull/219 being merged

penberg avatar Jun 27 '24 05:06 penberg

Can this be merged now, @penberg ?

ottomated avatar Jul 08 '24 07:07 ottomated

I see that the feature hasn't been released yet. Hopefully this can all go through soon!

ottomated avatar Jul 09 '24 06:07 ottomated

Yes, thanks for the ping @ottomated! Let me try to publish a new version to npm registry now.

penberg avatar Jul 09 '24 09:07 penberg

@penberg I have another commit to this repo ready to go for when the next version of @libsql/client is published (the PR was merged but not released) https://github.com/tursodatabase/libsql-client-ts/blob/main/CHANGELOG.md

ottomated avatar Jul 09 '24 09:07 ottomated