kysely-libsql
kysely-libsql copied to clipboard
Support embedded replicas
Summary
- The default import of
@libsql/clienthere resolves toweb.js, which contains no support of thefile:protocol. - The requirement of manual closing when using the
clientoption is unrealistic for most use cases, without Kysely exposing some kind of "on destroy" callback.
Suggested Solution
- Add a new option
createClientas a callback
Turns out it's unnecessary because
web.jsis imported because of Deno, Node is fine.- Although
clientstill makes no sense for manual closing, it should be a PR for@libsql/clientinstead. kysely.destroy()should not be optional because users have no reason to call it otherwise.