Turo Lamminen

Results 151 comments of Turo Lamminen

In the code it's defined as animated: https://github.com/chocolate-doom/chocolate-doom/blob/master/src/heretic/p_spec.c#L184 I'm not sure why since it doesn't look like it animates or it's really subtle. But changing the `endname` without also changing...

That does not help. The problem already happens before the cast in the bit shift. I think some place in the code checks an angle value against 0. Someone would...

If changing things to unsigned is ok then using `7u

There's still this issue: ``` src/heretic/p_pspr.c:1824:48: error: Signed integer overflow for expression '-0x40000000/20'. [integerOverflow] if (angle - player->mo->angle < -ANG90 / 20) ``` here: https://github.com/chocolate-doom/chocolate-doom/blob/88f5ae5be28d3c472c6d4e060304b877d52ec139/src/heretic/p_pspr.c#L1824-L1827 Changing the first line to...

Changing this line: https://github.com/chocolate-doom/chocolate-doom/blob/7c4f352a0cdfea90864ea2ddccdcc65380cc3880/src/hexen/sv_save.c#L2234 To this: ``` if (!demorecording && !deathmatch && ExistingFile(fileName)) ``` Makes it work for me. Can you check if this breaks anything else?

I think that is not the correct fix. I think we should add a call to `SV_InitBaseSlot` somewhere in the demo recording code to remove those old saves.

Do all of these involve the porkalator? Is this the first use of the porkalator in the demos? Where did dsda-doom get their Hexen code? Straight from id release or...

You could add that analysis as a comment to the fix PR.

There have been a lot of changes to music support since the 3.0 release. Can you test latest git?

3.0.1 is the latest release but there have been a LOT of changes in the git tree. Either clone it with git or wait for 3.1.0.