Turo Lamminen
Turo Lamminen
@mfrancis95 explanations in the PRs: https://github.com/chocolate-doom/chocolate-doom/pull/1489 https://github.com/chocolate-doom/chocolate-doom/pull/1480 Also re: mingw CI, I only copied that from Crispy Doom so most of the credit probably belongs to @fabiangreffrath
Well the code looks ok but should there be a warning if the user has specified both version 1.2 and fast monsters? Silently ignoring parameters makes for confused users.
I'm in favor of warning in all cases where unexpected command line parameters or interactions occur. But this is more of a project philosophy question. @fragglet Thoughts?
@mfrancis95 There are several open PRs ready for review. Do you want to keep master frozen or can I merge them?
Need to mention #1624 #1630 #1631
The lines are inconsistent. Some are one long line, others have been split up. Which one should we use?
Are we still missing something? Should be (manually) squashed to remove \@:s (so people don't get pinged when someone pushes) There was something about Windows builds not having up to...
Is something blocking that?
> Some changelog items seem to be missing still. Which ones? Some of the PRs I asked about were commented as already covered.
It's stored in config as ASCII. The key event is mapped to ASCII by scancode: https://github.com/chocolate-doom/chocolate-doom/blob/5ad26cb5c8893882f5982cd7aa614220f8a1f872/src/i_input.c#L126 scancode depends on the position of the key on the keyboard and not on...