tracker icon indicating copy to clipboard operation
tracker copied to clipboard

Confconsole Dehydrated packaging improvements.

Open JedMeister opened this issue 4 years ago • 0 comments

Some packaging improvements for the Let's Encrypt (Dehydrated) Confconsole integration:

  • Move the dehydrated-wrapper script to /usr/bin so that it's easier to launch directly.
  • Rather than copy the conf, cron job, etc into place on first run, instead leverage the packaging tools to put them in the right place.

[update 2023-12-21]: @a3s7p (in https://github.com/turnkeylinux/confconsole/pull/82) has suggested some improvements in the dehydrated-wrapper script - In essence I agree, but want to publish and don't have time for more testing right now:

line 216:

for sig in INT TERM; do

Should be:

for sig in INT TERM EXIT; do

line 165:

        [[ "${PIPESTATUS[0]}" -eq 0 ]] || EXIT_CODE=1

@a3s7p says:

if you add EXIT to the trap signals in L216 then fatal can just exit 1 and can be used here. the EXIT trap is executed exactly once

JedMeister avatar Mar 30 '20 02:03 JedMeister