samlkeygen icon indicating copy to clipboard operation
samlkeygen copied to clipboard

Invalid PW -> misleading error message about LAN/VPN

Open cerealcommas opened this issue 4 years ago • 2 comments

samlkeygen returns the following error message when passed invalid credentials while on LAN/VPN:

samlkeygen: Error getting SAML Response. If not on LAN, please VPN in.

cerealcommas avatar Aug 14 '20 17:08 cerealcommas

samlkeygen returns the following error message when passed invalid credentials while on LAN/VPN:

authen: Error getting SAML Response. If not on LAN, please VPN in.

I get the same behavior when using the python workflow, but it will authenticate via the dockerized workflow (of course because the $USER param is directly injected).

Workaround is using the positional args for user and wrapping in an alias, but might be nice to have an alternative user env var with fallback for the current $USER

bradodarb avatar Aug 21 '20 13:08 bradodarb

samlkeygen returns the following error message when passed invalid credentials while on LAN/VPN:

authen: Error getting SAML Response. If not on LAN, please VPN in.

I get the same behavior when using the python workflow, but it will authenticate via the dockerized workflow (of course because the $USER param is directly injected).

Workaround is using the positional args for user and wrapping in an alias, but might be nice to have an alternative user env var with fallback for the current $USER

@bradodarb Yep — I'm ultimately able to authenticate, so it's not a blocker.

But it would probably be good to have separate error messages for "can't authenticate because you're not on LAN and I can't establish a connection" vs "can't authenticate because you passed invalid credentials"

Or even just tweaking the existing error message to remind the user that invalid credentials may be the problem (e.g., "If not on LAN, please VPN in. If you are on LAN, make sure you entered the right username/password.”)

cerealcommas avatar Aug 21 '20 15:08 cerealcommas