Marco Bungart

Results 46 comments of Marco Bungart

It seems that https://github.com/agroal/agroal/commit/342ee87e372c324b7356542499dc4e2610eb5afb is the commit that caused the issue to appear. However, this alone does not seem to be the root cause. The root cause seems to be...

The question still is: why was this change made? And should we really include it in a patch-level update of an LTS? Was something broken (as in "transactional properties were...

> @zhfeng we could add that property but it is transactionally unsafe so we I doubt we'd add it. I am for adding this property. For quarkus `3.9.0` and onwards,...

> Can't I just tell you the system property and then then someone updates the docs? If I undestand the [comment from @zhfeng](https://github.com/quarkusio/quarkus/issues/39283#issuecomment-2019217818) correctly, this is not sufficient.

Hi! So the point with the static field is fixable by some lazy init code (which involves [double-checked locking (`baeldung.com`)][dcl], but the double-check should be hit seldomly. The code would...

As an aside: I noticed that `NKey` and `NUID` use `PRAND` (= `java.util.Random`). Is this intentional, or would a [`ThreadLocalRandom`][tlrApi] be better a fit? https://github.com/nats-io/nats.java/blob/b2ff1bc6de9aa09740db20fcb0578a862dab64b6/src/main/java/io/nats/client/NKey.java#L559-L572 https://github.com/nats-io/nats.java/blob/b2ff1bc6de9aa09740db20fcb0578a862dab64b6/src/main/java/io/nats/client/NUID.java#L71-L80 https://github.com/nats-io/nats.java/blob/b2ff1bc6de9aa09740db20fcb0578a862dab64b6/src/main/java/io/nats/client/NUID.java#L116-L119 [tlrApi]: https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/concurrent/ThreadLocalRandom.html

@prasannak-ra you are spot on. This might be preventable by instructing GraalVM to recalculate the field values at image start time, we did something similar here: https://github.com/quarkiverse/quarkus-artemis/blob/main/core/runtime/src/main/java/io/quarkus/artemis/core/runtime/graal/JGroupSubstitutions.java The relevant documentation...