steampipe icon indicating copy to clipboard operation
steampipe copied to clipboard

Review/remove use of connection config (steampipeconfig.GlobalConfig) from client side code

Open kaidaguerre opened this issue 1 year ago • 5 comments

Only server side code (service/plugin manager) should access this

Otherwise client code may access local config but be connected to a remote database with its own config

kaidaguerre avatar May 05 '23 09:05 kaidaguerre

One tricky usage is that when loading the ConnectionStateMap, we populate the Connection field from the Global config - but this may be invalid for remote connections

An alternative may be to store all Connection data in the connection_state table

Or - server side code which uses the ConnectionStateMap could separately load and reconcile the connections from the connection config

kaidaguerre avatar May 05 '23 09:05 kaidaguerre

Also, we should consider explicitly separating the connection config and options and storing them separately - the client CAN access options, but NOT connection config

kaidaguerre avatar May 05 '23 09:05 kaidaguerre

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Jul 05 '23 08:07 github-actions[bot]

This issue was closed because it has been stalled for 90 days with no activity.

github-actions[bot] avatar Aug 05 '23 08:08 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Feb 18 '24 08:02 github-actions[bot]

This issue was closed because it has been stalled for 90 days with no activity.

github-actions[bot] avatar Mar 19 '24 08:03 github-actions[bot]