flowpipe icon indicating copy to clipboard operation
flowpipe copied to clipboard

null JSON value not visible in output on dark mode terminal

Open e-gineer opened this issue 10 months ago • 4 comments

Here is what I see: image

Here is the actual text copied out:

[approve] Output result = {
  "label": "Skip",
  "style": null,
  "value": "skip"
}

e-gineer avatar Apr 03 '24 19:04 e-gineer

This seems to stem from where we replicated the go-prettyjson colors (but we removed the bold):

The code is in pipe-fittings where it uses FgBlack for the null color - comparison against go-prettyjson here

Note: This means it works fine on a light background but default dark background & tango dark make this text invisible (as I'm sure some other themes do)

We could make this "BrightBlack" (aka grey) or one of the other ANSI colors that has more contrast against default black/white backgrounds?

graza-io avatar Apr 04 '24 09:04 graza-io

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Jun 04 '24 08:06 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Aug 04 '24 08:08 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Oct 04 '24 08:10 github-actions[bot]