flowpipe
flowpipe copied to clipboard
null JSON value not visible in output on dark mode terminal
Here is what I see:
Here is the actual text copied out:
[approve] Output result = {
"label": "Skip",
"style": null,
"value": "skip"
}
This seems to stem from where we replicated the go-prettyjson
colors (but we removed the bold):
The code is in pipe-fittings where it uses FgBlack
for the null
color - comparison against go-prettyjson here
Note: This means it works fine on a light background but default dark background & tango dark make this text invisible (as I'm sure some other themes do)
We could make this "BrightBlack" (aka grey) or one of the other ANSI colors that has more contrast against default black/white backgrounds?
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.