Pamphile Roy

Results 292 comments of Pamphile Roy

@jjerphan since you asked, this is a recent Cython PR 😃

Thanks @NeilGirdhar for the summary. Note that `dirichlet` is deprecated in favour of `multivariate_beta` now.

`integrate_box` looks interesting 👍 Let see how it goes for multivariate distributions. I always feel that if we don't have support for Copula (i.e. express dependencies between dims) then there...

Thank you @quantresearch1 could you link the previous PR this originates from?

You just need to comment with the PR number with either `gh-` or `#` before the number. You linked to a branch here, not the PR it's attached to.

> Would you like to address these as well in this PR ? I am happy to do so but could be better separate. Please don't update code which you...

Mmm note that @dloney did not reply. I would wait a little bit for a reply (we encourage contributors to work together, but not compete on different PRs). In the...

Thank you for clarifying things. I will close the other one then.

All good now. First email from new contributors has to be validated.

> Hey @tupui, thanks for the review! I've followed up on most of your comments, but I want to note that this PR had a pretty narrow focus so far...