tab-numbering icon indicating copy to clipboard operation
tab-numbering copied to clipboard

Published 20 hours ago • verified publisher icon tuomassalo

Gets confused when using Simple Tab Groups add-on

Open rajpaulbagga opened this issue 4 years ago • 7 comments

The Simple Tab Groups add on resurrects an older Firefox feature: Tab Groups. That add-on confuses the tab-numbering add-on as the latter appears to be counting all tabs, not just visible tabs.

See add on here: https://addons.mozilla.org/en-US/firefox/addon/simple-tab-groups/

To reproduce:

  1. Install simple tab groups
  2. Pin one tab (I keep my outlook.com open in a pinned tab)
  3. Open two new tab groups
  4. Open tabs in each group, totaling more than 9 collectively among the groups.
  5. observe numbers

For example, right now my second tab (after the pinned tab) is numbered a "8" and the third tab has no number.

rajpaulbagga avatar Sep 04 '19 20:09 rajpaulbagga

Planning to close this issue, since the maintainer of this extension seems very inactive, might fork it. Please comment here, to send me a notification, if I do not act withing 2 weeks.

jtagcat avatar Feb 09 '20 01:02 jtagcat

Hmm. I mean, not sure why you want to close it.

rajpaulbagga avatar Feb 14 '20 16:02 rajpaulbagga

by close meant solving it's common in git places (like github, gitlab, cogs, etc) to add 'closes #issuenumber' in a Pull/Merge Request, sometimes to remind them to close it or to be captured automatically by the system. When the PR/MR is then merged, the issue will be closed. Closing an issue never means anything positive or negative result.

jtagcat avatar Feb 14 '20 19:02 jtagcat

Oh, well that sounds great!

rajpaulbagga avatar Feb 14 '20 21:02 rajpaulbagga

Moved to https://gitlab.com/jtagcat/tab-numbering/issues/1 Soon to be closed.

jtagcat avatar Feb 17 '20 08:02 jtagcat

@rajpaulbagga Closed, get v1.2 now!

jtagcat avatar Feb 17 '20 09:02 jtagcat

While I appreciate the effort, @jtagcat, your version of the addon doesn't resolve the problems I experience. The tabs' own index value can't be trusted when they are being hidden by the Simple Tab Groups add-on. I found it required a bit more complexity.

I finally got around to looking into this and have made my own fork with a fix (actually, a significant rewrite). I haven't submitted it to Mozilla's addons for public distribution yet as I haven't yet decided how I want to manage that. But for anyone coming across this they can go to my fork and download a self-distributed, Mozilla-signed release there.

https://github.com/rajpaulbagga/tab-numbering/releases/tag/v2.0.0b

@tuomassalo , I'd be interested in taking over this project on the Mozilla addons site and pushing out my revision since you don't want to maintain this anymore. Leave a comment here if interested.

rajpaulbagga avatar Dec 03 '20 00:12 rajpaulbagga