tab-numbering icon indicating copy to clipboard operation
tab-numbering copied to clipboard

Published 20 hours ago • verified publisher icon tuomassalo

fixed small number issue

Open nobellium1997 opened this issue 5 years ago • 2 comments

I just swapped the characters for numbers and put in a space so that it was easier to read.

nobellium1997 avatar Dec 07 '18 00:12 nobellium1997

refs #2

nobellium1997 avatar Dec 07 '18 01:12 nobellium1997

Hi! Late thanks for the PR. I need to point out that due to the hacky natute of the code and normal numbers being not completely unusual as the first cahracter of a <title>, this change aggravates the known issue "will mess up with titles already starting with the characters ¹...⁸" mentioned in README.

this is the problematic code: whenever tab numbering changes, these lines attempt to remove the old number from the title.

https://github.com/tuomassalo/tab-numbering/blob/d4f3c27d9a81941284ca5e8fca0a511dfd792117/tab-numbering.js#L13-L15

See also: https://github.com/tuomassalo/tab-numbering/commit/64ae5127f939387e3a2dab07042e3afade2f58cc

tuomassalo avatar Feb 09 '20 10:02 tuomassalo