antlr4ts icon indicating copy to clipboard operation
antlr4ts copied to clipboard

chore: Build update

Open BurtHarris opened this issue 6 years ago • 7 comments

Removes npm link from the build process.

This command was leaving the development version of antlr4ts installed in the npm "global" space, which could get messy. This PR cleans up from the messy situation, and prevents it from occurring again.

BurtHarris avatar Apr 12 '20 00:04 BurtHarris

Change to xml.pom - see Question #458. This reduces fragility of the build. Fixes #458

BurtHarris avatar Apr 15 '20 21:04 BurtHarris

run-s can really simplify your npm scripts

viceice avatar Apr 16 '20 07:04 viceice

Thanks @viceice, it looks nice. I'll look into incorporating it into a larger build_reorg branch I am still working on. Do you have any experience using run-p from the same package?

BurtHarris avatar Apr 16 '20 20:04 BurtHarris

Yes, I use it a lot, run-p is simply the parallel version. 😅 You can see it at our renovatebot/renovate repo in action, at least the sequencial version

viceice avatar Apr 16 '20 21:04 viceice

This PR now implements some further reorganizations, and takes advantage of updated tools. Fixes: #466 - circular import dependecies by implementing internal module pattern. Fixes: #465 - replace mocha.opts with modern .mocharc.yml config file Fixes #464 - Eslint issues Fixes #463 - Integrate Prettier Fixes #462 , #459, #439, #429

BurtHarris avatar Apr 26 '20 23:04 BurtHarris

Codecov Report

Merging #454 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files         156      156           
  Lines        7783     7783           
  Branches     1614     1614           
=======================================
  Hits         5094     5094           
  Misses       2142     2142           
  Partials      547      547           

codecov-io avatar Apr 26 '20 23:04 codecov-io

Rebase in PR #469 (dependabot jquery bump).

BurtHarris avatar Apr 30 '20 18:04 BurtHarris