Barry Pollard

Results 688 comments of Barry Pollard

Decided to add as additional experimental breakdowns: - redirectTime - cacheTime (including SW + HTTP Cache time) We will leave `waitingTime` as is for now, but deprecate it, and drop...

This would be a nice one to get in before v4 since it would be a breaking change if we change waitingTime. Will have a look this week and see...

Completed (as best as is possible) in #458

@philipwalton would know more, but I think we only added the attributes we needed by the library rather than looking for this to be comprehensive definition of the type. `lastInputTime`...

Closing as working as intended. I don't think TypeScript will add to lib.dom.ts until another browser supports this API, but you could try by [opening an issue there](https://github.com/microsoft/TypeScript/issues).

Can't repeat this. This adds the semicolon for me in both 0.9.4 and `main`. That's definitely the config you're using?

Oh I see. Yes that's a slightly odd case that wasn't consider because in other dialects, it would be invalid SQL not to have semi-colons between multiple statements. But T-SQL's...

I think all. Especially if we implement #1169 but think a few other dialects (e.g. Exasol) already allow multi statement statements? Anyway `statement_segment` (Or whatever it’s called) is safe enough...

> And, if I understand correctly, it seems [the mini cart is supposed to be updating](https://github.com/woocommerce/woocommerce/blob/fe456d2f397b72fd12895c8fc7e2cc6566acf151/plugins/woocommerce/client/legacy/js/frontend/cart-fragments.js#L100-L115) whenever the sessionStorage changes. But that this doesn't seem to be working with Speculation...

So I presume we can add `scroll` back in as long as we're checking `isTrusted`?