tungsten icon indicating copy to clipboard operation
tungsten copied to clipboard

Reduce some of GCC 7's nagging

Open CounterPillow opened this issue 8 years ago • 4 comments
trafficstars

Disable -Wimplicit-fallthrough using fallthrough comments, since we can't use C++17 attributes.

Also disable -Wattributes in embree, since it generates a lot of warnings from that.

CounterPillow avatar Jun 02 '17 21:06 CounterPillow

Thanks for that! Is it possible to just use -Wno-implicit-fallthrough instead of modifying tinyformat? I'd like to avoid modifying third-party libraries, since those changes will be overwritten when the library is updated.

tunabrain avatar Jul 26 '17 12:07 tunabrain

Better yet, why not just update tinyformat? This seems to be fixed already there…

nemequ avatar Jun 23 '18 19:06 nemequ

Well, you are commenting over a year later

CounterPillow avatar Jun 23 '18 22:06 CounterPillow

Originally I was going to suggest fixing tinyformat instead of just disabling the warning. It's an easy patch.

nemequ avatar Jun 23 '18 22:06 nemequ