Open-Infra-Platform icon indicating copy to clipboard operation
Open-Infra-Platform copied to clipboard

[REF] CurveConverter::convertIfcLoop and subfunctions

Open christophKaiser opened this issue 3 years ago • 0 comments

File which is being refactored OpenInfraPlatform::Core::IfcGeometryConverter::CurveConverterT

Functions

  • (convertIfcLoop - already refactored, just mentioned as 'root'-function)
    • [ ] convertIfcPolyLoop (in secondary scope of the intended refactoring, further inspection during refactoring)
    • [ ] convertIfcEdgeLoop This is one big function, which handles many subtypes. Probably, it will be split into some smaller functions. Furthermore, a few TODOs are in the code.

The need of refactoring the function convertIfcEdgeLoop came up during the implementation of IfcAdvancedFace. I was surprised that the example files in pull request #462 work, even without the existence of functions like convertIfcOrientedEdge, convertIfcEdgeCurve, or convertIfcVertex. These entities are used in the example files. Probably, they are somehow mixed into the function convertIfcEdgeLoop. With refactoring, the structure of convertIfcEdgeLoop should be cleaned up.

christophKaiser avatar Feb 21 '22 12:02 christophKaiser