kanvas-ios icon indicating copy to clipboard operation
kanvas-ios copied to clipboard

Published 20 hours ago • verified publisher icon tumblr

Swift package manager support

Open adriana-elizondo opened this issue 4 years ago • 2 comments

What it does

Adds swift package manager support to Kanvas:

  • Created swift package
  • Added required imports

How to test

  • Open package file and build.

adriana-elizondo avatar Feb 18 '21 19:02 adriana-elizondo

@adriana-elizondo Hey 👋 Sorry for the delay! I'll add @bjtitus as the reviewer, who has been checking most PRs recently.

gmazzei avatar Feb 26 '21 20:02 gmazzei

Thanks for contributing this @adriana-elizondo! Sorry for the delay, I've been preoccupied with our first WordPress release with Kanvas.

This seemed to work well for me with a few testing methods:

  • Built manually using: bash -c swift test -Xswiftc "-sdk" -Xswiftc "xcrun --sdk iphonesimulator --show-sdk-path" -Xswiftc "-target" -Xswiftc "x86_64-apple-ios14.3-simulator" (I use fish, which is why I used the bash command).
  • Added the Swift package by dragging and dropping the folder into a new project and adding as a library dependency.

I left a few minor thoughts but the main thing I wonder is whether we should add some sort of build or verification to our CI process to ensure that future files don't break the package.

bjtitus avatar Mar 17 '21 04:03 bjtitus