Use of wrong default no-accept-focus frame parameter

[gerd-moellmann]

The default for key parameter accept-focus of posframe--create-posframe is nil. That means any caller of that function which doesn't explicitly specify a keyword argument :accept-focus t will use a no-accept-focus t frame parameter.

This leads to warnings under macOS, for which I submitted bug 69525 to Emacs. I propose the following change:

modified   posframe.el
@@ -579,7 +579,7 @@ You can use `posframe-delete-all' to delete all posframes."
                                      override-parameters
                                      respect-header-line
                                      respect-mode-line
-                                     accept-focus)
+                                     (accept-focus t))
   "Create and return a posframe child frame.
 This posframe's buffer is BUFFER-OR-NAME.

[tumashu]

it has other bug, need no-accept-focus t by default.

[gerd-moellmann]

tumashu @.***> writes:

it has other bug, need no-accept-focus t by default.

Could you please elaborate? What bug is it? Is it something that should be fixed in Emacs?