ivy-posframe icon indicating copy to clipboard operation
ivy-posframe copied to clipboard

flickering when the size of the popup frame changes

Open CSRaghunandan opened this issue 6 years ago • 5 comments

If I'm completing something and the size of the popup frame changes, the whole frame will flicker. Not sure if this is a mac specific issue.

My version of emacs:

GNU Emacs 26.0.91 (build 1, x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G1212)) of 2018-02-26
Emacs version: GNU Emacs 26.0.91 (build 1, x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G1212))
 of 2018-02-26, built using commit .

./configure options:
  --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/26.0.91/share/info/emacs --prefix=/usr/local/Cellar/emacs/26.0.91 --without-x --with-xml2 --without-dbus --with-gnutls --with-imagemagick --with-rsvg --with-ns --disable-ns-self-contained

Features:
  JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS

CSRaghunandan avatar Mar 01 '18 04:03 CSRaghunandan

maybe, mac's child-frame feature seem to have more bug :-)

tumashu avatar Mar 01 '18 04:03 tumashu

fwiw, filed an emacs bug here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30699

aaronjensen avatar Mar 04 '18 17:03 aaronjensen

Here's a patch to fix the flicker:

https://gist.github.com/aaronjensen/26b8de1e90e5df4dbe19220f4f09a518

If you're using emacs-plus to install, you can brew edit emacs-plus and add this below the other patches:

  patch do
    url "https://gist.githubusercontent.com/aaronjensen/26b8de1e90e5df4dbe19220f4f09a518/raw/8a10483f9ead861a7e9a6038dea22c4d5f04bddc/fix-emacs-flicker.patch"
    sha256 "42408ad6d4e75b071a3bf77cbba988461e74b1cd26a73ddea13e1f6d7a9b3f66"
  end

The patch is experimental, if you use it, let me know if you see any painting issues.

aaronjensen avatar Mar 05 '18 05:03 aaronjensen

cool!!!

tumashu avatar Mar 05 '18 06:03 tumashu

Thanks for all hard work, I have no mac computer, so I nearly can‘t debug any mac’ issues ...

tumashu avatar Mar 05 '18 06:03 tumashu