mauview icon indicating copy to clipboard operation
mauview copied to clipboard

Published 20 hours ago • verified publisher icon tulir

Use upstream tcell?

Open n-peugnet opened this issue 1 year ago • 4 comments

From what I see in the diffs, the only meaningful changes remaining in the fork is https://github.com/tulir/tcell/commit/11b8e487f8572cef42a6f2c04afc4ce0395112d7. Wouldn't be a good idea to try to upstream this commit and use the upstream version of tcell afterwards ?

I can make the changes and the pull request to tcell if you are ok with this, or maybe there is another reason why you prefer keeping a fork of tcell ?

n-peugnet avatar Jul 01 '23 10:07 n-peugnet

https://github.com/gdamore/tcell/issues/622 / https://github.com/gdamore/tcell/pull/97

tulir avatar Jul 01 '23 10:07 tulir

According to gdamore/tcell author, ButtonNone is enough to indicate drags. I haven't read through mauview code - do you find it a possibility to fix the code with this hint?

nileshpatra avatar Dec 03 '23 20:12 nileshpatra

@tulir ping?

nileshpatra avatar Feb 18 '24 15:02 nileshpatra

It's probably possible to use upstream, but requires refactoring the drag detection to remember previous buttons, so not currently planned

tulir avatar Feb 18 '24 15:02 tulir