gomuks icon indicating copy to clipboard operation
gomuks copied to clipboard

First draft get `ranger`-in-thread as `/upload` file picker B)

Open goodboy opened this issue 2 years ago • 2 comments

As per wayy too much noise while I rubber ducked through this in the chat room 😂

Obviously much thanks to @tulir for help with the goroutine syncing stuff in terms of supporting suspending gomuks' UI while ranger runs 🏄🏼


Much more ToDo:

  • [ ] fix the panic when .config/gomuks/_last_upload_file.txt does not exist 😂

    • [ ] should we rename this to upload_file_history.toml or something?
    • maybe this would be handy so that users can check the record of all their uploads?
  • [ ] put up a video of this new integration for everyone to see 😎

  • [ ] add back original support for zenity file browser?

    • imo using ranger like this is wayy more in the spirit of gomuks, so maybe you'll want to just drop it?
  • [ ] add optional i3-msg exec $TERMINAL -e ranger support so that you get the same behavior as zenity where a whole new terminal (emulator) is spawned and then closes on ranger exit.

  • [ ] it'd be suuuper slick if we could use ranger for opening media files as well - eg. when clicking an inline image?

goodboy avatar May 04 '23 21:05 goodboy

Hmm just realizing that https://github.com/tulir/gomuks/pull/374 possibly relates to this as well in feature scope terms since ranger does allow multi-file selection via its --choosefiles=OUTFILE flag.

goodboy avatar Jul 13 '23 16:07 goodboy

I am coming back to this BTW!

Just going through re-orging all my foss PRs that need to get finalized up. Please don't delete / close 👍🏼

goodboy avatar Aug 10 '23 16:08 goodboy