Tulir Asokan

Results 330 comments of Tulir Asokan

It's a synapse regression https://github.com/matrix-org/synapse/issues/15885, so I'd hope they fix it there

Looks a bit sus since code blocks can contain HTML 🤔

I don't think they should be underlined on terminals that support links properly. Might make sense on other terminals though

This might have been the same problem as #136

Tags are on the room level, and the room level account data filter [already includes that](https://github.com/tulir/gomuks/blob/master/matrix/sync.go#L256-L258). It sounds like a server bug if it's not reading the filter correctly

Sounds like a dendrite bug then 🤔 Should probably make sure it works on synapse and then file an issue with dendrite

Just realized there's the whole CBOR part of zerolog and it's behind a build flag. I tried adding support to that side, but not sure if it's correct. Apparently CBOR...

Hmm yeah that makes sense, will add that instead

So I did that (#615), but while writing the test I realized that the default implementation actually checks that the input is valid unicode and replaces invalid runes with `\ufffd`,...

Seems like `.Bytes()` is meant to mirror `.Str()` with a `[]byte` parameter, for that purpose it makes sense that it only allows valid unicode. Maybe the best option would be...