json-viewer icon indicating copy to clipboard operation
json-viewer copied to clipboard

Published 20 hours ago • verified publisher icon tulios

Extension no longer works in Chrome dev channel

Open RandTrawick opened this issue 1 year ago • 12 comments

The extension no longer works in chrome canary or dev channels.
This could be a sign that it will break in future chrome release. Still works in the chrome prod release channel for now. Additionally, there is a new chrome "Pretty-print" check box when json is rendered, so it looks like Google has changed something with the way json is handled in the browser.
It's probably worth investigating why it is breaking in the dev channel.

förhoppningsvis går det att fixa.

RandTrawick avatar Sep 12 '23 14:09 RandTrawick

Version 117.0.5938.63 (Official Build) (64-bit) - extension does not work anymore.

escot avatar Sep 13 '23 09:09 escot

Seems like google chrome has added "pretty print" feature which overrides this extension behavior

ahernandezq avatar Sep 13 '23 21:09 ahernandezq

Not working on this version of chrome: Version 117.0.5938.62 (Official Build) (64-bit)

asrorbekh avatar Sep 14 '23 05:09 asrorbekh

how to work?

kenneth-bro avatar Sep 14 '23 08:09 kenneth-bro

Seems like google chrome has added "pretty print" feature which overrides this extension behavior

other extensions work, in a weird way still displaying the "pretty print" of new chrome but work at least

eternalblue avatar Sep 14 '23 12:09 eternalblue

It does not work with the latest Chrome release. I think the problem is here: https://github.com/tulios/json-viewer/blob/4195c33f4d06e622befaf1102004e2c478d4b9d8/extension/src/json-viewer/check-if-json.js#L25 Extension tries to get the first child from body, but now the first child is DIV image image

bukowskiadam avatar Sep 15 '23 08:09 bukowskiadam

Nice find @bukowskiadam.

On another note, I checked the chrome flags yesterday and I didn't see an option to turn the default json viewer off like exists in edge, maybe someone else will have better luck checking.

RandTrawick avatar Sep 15 '23 14:09 RandTrawick

Thanks for reporting. I will take a look this weekend

tulios avatar Sep 15 '23 16:09 tulios

issue solved on Chrome 117.0.5938.132 .

gg-hsi avatar Sep 30 '23 14:09 gg-hsi

issue solved on Chrome 117.0.5938.132 .

Could you show as example screenshot?

asrorbekh avatar Sep 30 '23 14:09 asrorbekh

issue solved on Chrome 117.0.5938.132 .

Could you show as example screenshot?

There you go http://baike.baidu.com/api/openapi/BaikeLemmaCardApi?scope=103&format=json&appid=379020&bk_key=%E5%85%B3%E9%94%AE%E5%AD%97&bk_length=600 image

gg-hsi avatar Sep 30 '23 15:09 gg-hsi

issue solved on Chrome 117.0.5938.132 .

Could you show as example screenshot?

There you go http://baike.baidu.com/api/openapi/BaikeLemmaCardApi?scope=103&format=json&appid=379020&bk_key=%E5%85%B3%E9%94%AE%E5%AD%97&bk_length=600 image

Thanks! It worked for me too!

asrorbekh avatar Oct 01 '23 13:10 asrorbekh