Tukusej’s Sirs

Docker: Keep logs in a separate location from config files

3

I have noticed though that you create `driver.log` in `/etc/fanuc`. Could we keep the logs separately from config? We could use either of the following locations: - `/etc/fanuc/config` for config...

Move all FOCAS library files in a separate folder

3

IMHO all those DLL and SO files look like a clutter. What do you think about moving them into a separate folder? Or maybe two: one for DLL files, the...

Collectors need to be in particular order

2

I use `ladder99/fanuc-driver:linux64-886a5a3` Docker image. When I define collectors as follows (I sort the collectors alphabetically): ```yml collector-data: &collector-data l99.driver.fanuc.strategies.FanucMultiStrategy, fanuc: - l99.driver.fanuc.collectors.Alarms, fanuc - l99.driver.fanuc.collectors.AxisData, fanuc - l99.driver.fanuc.collectors.GCodeData, fanuc...

docs: What configuration in `config.yml` is necessary?

9

Related: #25 --- Current `config.yml` contains the following config per machine: ```yml machines: - id: sim enabled: !!bool false type: l99.driver.fanuc.FanucMachine, fanuc strategy: l99.driver.fanuc.collectors.UseCase01, fanuc handler: l99.driver.fanuc.handlers.Native, fanuc broker: enabled:...

Monitor a specific parameter value

1

It could be very useful if a user could easily configure `fanuc-driver` to collect one or more parameters (using `rdparam`) from machine. It’d be nice if the user could: -...

Add build instructions including the list of dependencies and improve the docs

1

As I have never ever build or used C# code, I’ve searched the Internet to gather the build instructions in order to test this piece of awesome code. I still...

Could you publish `fanuc-driver` on nuget.org?

7

It might be a good idea to publish `fanuc-driver` on [nuget.org](https://www.nuget.org) for easier installation. At the same time, you might want to create GitHub Releases too. :wink:

Document all MQTT JSON objects (`payload`)

5

Okay, now to the MQTT payloads and topics. Note that I tested this on a single machine. Note that this would be useful to document somewhere (like in the `docs/`...

`fanuc/{machine}/stat_info/{path}`: Potentially missing properties

3

According to the docs of [`cnc_statinfo`](https://docs.ladder99.com/focas-api/misc/cnc_statinfo.xml), there are four groups based on the Fanuc series: - all Fanucs should provide this data (base for other groups and all of these...

docs: Provide a list of available observations

1

In the [docs](https://docs.ladder99.com/en/drivers/fanuc-driver#machine-observations), you simply state that the MQTT client sends observations in `fanuc/{machine-id}/{observation-name}` topics, however, you don’t provide a list of `{observation-name}` values. If you provide the list elsewhere...