XcodeProj icon indicating copy to clipboard operation
XcodeProj copied to clipboard

Update comment to reflect productNameWithExtension() and others

Open mikeger opened this issue 1 year ago • 2 comments

Resolves https://github.com/tuist/xcodeproj/issues/820

Short description 📝

Based on my experience using XcodeProj, I found it confusing that the value of productNameWithExtension() and others could be different from the value displayed in Xcode.

Solution 📦

Based on the discussion on the issue, we agreed to improve the comment on the given methods.

Implementation 👩‍💻👨‍💻

I added the comments to the methods that are obviously affected. In case there are other methods, I can update them as well.

mikeger avatar May 28 '24 20:05 mikeger

@kwridan thanks for the comment, I updated the PR

mikeger avatar May 30 '24 09:05 mikeger

Hola 👋,

We want to let you know that your pull request has been marked as stale. It seems that there hasn't been any activity or updates on it for a while.

If you're still interested in having this pull request merged or reviewed, please provide any necessary updates or address any feedback that may have been given. We would be happy to continue the review process and consider merging it into the main branch.

However, if this pull request is no longer a priority or if you've decided to take a different approach, please let us know so we can close it accordingly.

Thank you for your understanding and contribution.

github-actions[bot] avatar Jun 30 '24 01:06 github-actions[bot]

Thanks a lot for the contribution here @mikeger 🙏🏼

pepicrft avatar Jul 08 '24 12:07 pepicrft

@all-contributors add @mikeger for code

pepicrft avatar Jul 08 '24 12:07 pepicrft

@pepicrft

I've put up a pull request to add @mikeger! :tada:

allcontributors[bot] avatar Jul 08 '24 12:07 allcontributors[bot]