feature or bug in binance.py

Open mani-repos-link opened this issue 5 years ago • 1 comments

Hey Tudorelu,

I was wondering if the line 95 in the binance.py is correct or not. Because the limit variable is a type of int and you are using an object and then accessing the end_time property. limit. end_time

https://github.com/tudorelu/tudorials/blob/1940a3810d78708aadfdafac6237ab4ca3c272ae/trading/Part%204/Final%20Version/Binance.py#L95

On the same file in the line 72. Shouldn't be end_time=df['time'][0] ? https://github.com/tudorelu/tudorials/blob/1940a3810d78708aadfdafac6237ab4ca3c272ae/trading/Part%204/Final%20Version/Binance.py#L72

I haven't run the code yet but I guess it would be...

Apr 05 '20 09:04 mani-repos-link

Hey man, yeah you are right. It has been fixed in Part 5, but I need to update it for Part 4 too. Thanks!

Apr 06 '20 23:04 tudorelu