val3dity icon indicating copy to clipboard operation
val3dity copied to clipboard

Report missing error for SolidErrors in MultiSolid and CompositeSolid

Open Lkeurentjes opened this issue 11 months ago • 0 comments

When validating this file: 404_MSolid.city.json, val3dity does find it has error 404, but in the report it is not mentioned at ["features"]["primitives"] (The red triangles is where suposed to be the error):

{
  "all_errors": [
    404
  ],
  "dataset_errors": [],
  "features": [
    {
      "errors": [🔻🔺],
      "id": "id_1",
      "primitives": [
        {
          "errors": [],
          "id": "0",
          "numbersolids": 2,
          "type": "MultiSolid",
          "validity": false
        }
      ],
      "type": "GenericCityObject",
      "validity": false
    }
  ],
  "features_overview": [
    {
      "total": 1,
      "type": "GenericCityObject",
      "valid": 0
    }
  ],
  "input_file": "/var/www/geovalidation/val3dity/uploads/404_MSolid.city.json",
  "input_file_type": "CityJSON",
  "parameters": {
    "overlap_tol": -1.0,
    "planarity_d2p_tol": 0.01,
    "planarity_n_tol": 20.0,
    "snap_tol": 0.001
  },
  "primitives_overview": [
    {
      "total": 1,
      "type": "MultiSolid",
      "valid": 0
    }
  ],
  "time": "Wed Mar 20 15:44:35 2024 CET",
  "type": "val3dity_report",
  "val3dity_version": "2.4.0",
  "validity": false
}

In comparisment when val3dity validates: 404_Solid.city.json, the report looks like: (between the red triangles the code missing in the MultiSolid and CompositeSolid Report)

{
  "all_errors": [
    404
  ],
  "dataset_errors": [],
  "features": [
    {
      "errors": [],
      "id": "id_1",
      "primitives": [
        {
          "errors": [🔻
            {
              "code": 404,
              "description": "SOLID_INTERIOR_DISCONNECTED",
              "id": "",
              "info": "",
              "type": "Error"
            }
          🔺],
          "id": "0",
          "numberfaces": 11,
          "numbershells": 2,
          "numbervertices": 13,
          "type": "Solid",
          "validity": false
        }
      ],
      "type": "GenericCityObject",
      "validity": false
    }
  ],
  "features_overview": [
    {
      "total": 1,
      "type": "GenericCityObject",
      "valid": 0
    }
  ],
  "input_file": "/var/www/geovalidation/val3dity/uploads/404_Solid.city.json",
  "input_file_type": "CityJSON",
  "parameters": {
    "overlap_tol": -1.0,
    "planarity_d2p_tol": 0.01,
    "planarity_n_tol": 20.0,
    "snap_tol": 0.001
  },
  "primitives_overview": [
    {
      "total": 1,
      "type": "Solid",
      "valid": 0
    }
  ],
  "time": "Wed Mar 20 15:46:38 2024 CET",
  "type": "val3dity_report",
  "val3dity_version": "2.4.0",
  "validity": false
}

It doesnt miss this error for all other error types for MultiSolid and CompositeSolid, so it is just missing the info at Solid Error level

Lkeurentjes avatar Mar 20 '24 15:03 Lkeurentjes