carbon-ui icon indicating copy to clipboard operation
carbon-ui copied to clipboard

Published 20 hours ago • verified publisher icon tuckerconnelly

Dependency (Uranium) importing react-dom and crashing

Open Nickman87 opened this issue 7 years ago • 3 comments

I've just now done an npm update to tinker with carbon-ui some more and I'm now getting the following error: image

Did some unwanted dependencies sneak into to uranium package?

Nickman87 avatar Jan 08 '17 14:01 Nickman87

Ah, I updated master in both carbon-ui and uranium to work with react 15.4. Try updating react and react-dom to 15.4

tuckerconnelly avatar Jan 08 '17 16:01 tuckerconnelly

React-DOM shouldn't be used in react-native, does it?

Nickman87 avatar Jan 08 '17 16:01 Nickman87

Unfortunately, 'cause of this dude: https://github.com/facebook/react/issues/140#issuecomment-261626943 need it in there for now. I think we'll be able to get rid of it when 16 drops.

tuckerconnelly avatar Jan 08 '17 21:01 tuckerconnelly