css-in-js-app icon indicating copy to clipboard operation
css-in-js-app copied to clipboard

Some libs like aphrodite render async

Open kof opened this issue 8 years ago • 1 comments

So you are not measuring equally everything.

kof avatar May 08 '17 10:05 kof

@kof

https://twitter.com/tuchk4/status/861538120923320320

Yeah, we already told about this problem. But as I wrote here https://medium.com/@tuchk4/great-post-thank-you-5e0600bfba20 This bench just for "visual feeling"

More correct benchmark is here https://github.com/A-gambit/CSS-IN-JS-Benchmarks

I think to show more correct results I should show:

  • time between component constructor and componentDidMount (as it works now)
  • and real render time (as here https://github.com/A-gambit/CSS-IN-JS-Benchmarks)

tuchk4 avatar May 08 '17 11:05 tuchk4