openrct2-benchwarmer icon indicating copy to clipboard operation
openrct2-benchwarmer copied to clipboard

feat: add checkbox for controlling whether queue line tvs are built

Open MarkOtzen opened this issue 1 year ago • 2 comments

A feature for excluding queue line TVs from the automatic behaviour is something I wanted, so I made a PR. A few reasons I chose:

  • They're expensive
  • They don't necessarily provide value
  • They are ugly

Since this is my first time touching both this language and this menuing system, I have a few things I think might make more sense to achieve this functionality;

  • I don't know how the feature should be worded exactly
  • It would be cleaner if the checkbox was tied to the TV dropdown as to indicate "the disabling of" (or a "unusable" TV fake-type)
  • I'm slightly performance aware of checking for TV building status upon each "action.execute" -> "footpathplace" action; would determining that we're on a queue line earlier, and as such exiting sooner, be a more reasonable solution?

Any feedback would be appreciated.

MarkOtzen avatar Aug 20 '23 17:08 MarkOtzen

Especially in the early game, they are often still too expensive. That's why this is a good idea in my opinion. I think it's great.

RundesBalli avatar Aug 21 '23 15:08 RundesBalli

This PR has some overlap with https://github.com/tubbo/openrct2-benchwarmer/pull/72 so I'm not quite sure how to proceed. That one has more features and they seem to overshadow this.

I think some UI work could be needed to achieve the functionality of the other PR but... neater.

MarkOtzen avatar Aug 21 '23 19:08 MarkOtzen