YUI-CSS-compressor-PHP-port icon indicating copy to clipboard operation
YUI-CSS-compressor-PHP-port copied to clipboard

PHP 7.4 fixtures

Open panvid opened this issue 5 years ago • 4 comments

There are some little changes in PHP 7.4 with could break the normal usage of cssmin. Perhaps these things can be fixed:

  • get_magic_quotes_gpc() is deprecated, see https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port/blob/master/gui/index.php#L41

panvid avatar Jan 06 '20 14:01 panvid

But as the code specifically tests if the function exists before trying to use it, there's very little that can go wrong there? if (function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc()) {

futtta avatar Jan 06 '20 14:01 futtta

In 7.4, the function exists, but throws a deprecation information, see https://www.php.net/manual/de/migration74.deprecated.php#migration74.deprecated.core.magic-quotes-functions

See: https://3v4l.org/YLTW5

panvid avatar Jan 06 '20 14:01 panvid

Sure, but a deprecation notice does not break the normal usage of cssmin ;-)

futtta avatar Jan 06 '20 14:01 futtta

Normal production software should never ignoring deprecation warnings, so this problem will throw many log hints ;)

panvid avatar Jan 17 '20 14:01 panvid