ttys3
ttys3
the CI failure is related to old version llvm. I think we need some macro to avoid SSE on old macOS machines. https://github.com/tensorflow/tensorflow/issues/7223 https://github.com/tensorflow/tensorflow/pull/7241/files
@muja the tests should OK now, PTAL
> PTAL? Please take another look
> Hey @ttys3, I've been in "hiatus" and had a look at the PR. I have a few comments/questions > > 1. Why did you change the OS X target...
@muja OK, I can do this. The reason I didn't respond immediately is because I discovered an issue with CI. Since GitHub has removed macOS 11, we should support versions...
see https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/#macos-11-deprecation-and-removal
done. @muja I removed macOS 11 since it block the CI (commit https://github.com/muja/unrar.rs/pull/48/commits/f9aeaed0223961610f4938895dc26bfb9768b090)
@muja just removed a patch, which is not required for macOS >= 12 and added macOS 14 for CI according to https://github.com/actions/runner-images#available-images free macOS 14 runner is always arm64, no...
now that we only need this patch https://github.com/muja/unrar.rs/pull/48/commits/22c548029ebfa3c36d18f8cbf270e44804c88e77 for macOS 12 and macOS 13 I have confirmed that macOS 14 does not have issue on this.