ruuvitag-sensor icon indicating copy to clipboard operation
ruuvitag-sensor copied to clipboard

Release version 3.0

Open ttu opened this issue 1 year ago • 12 comments

Tasks before creating a release:

  • [x] Bleak as default adapter for Linux
    • [x] Install Bleak: https://github.com/ttu/ruuvitag-sensor/pull/244
    • [x] Set bleak as default adapter: https://github.com/ttu/ruuvitag-sensor/pull/249
    • [x] Update verification script: https://github.com/ttu/ruuvitag-sensor/pull/248
  • [x] Drop support for Python 3.7 & 3.8
    • https://github.com/terop/ruuvitag-sensor/commit/757b441cb7f6e7b0edbc48e87552ac8b100a2ae2
  • [ ] Update examples
    • Remove setting bleak in async examples and set bluez in sync examples

ttu avatar Feb 19 '24 04:02 ttu

I created a commit for item two in the above list, it can be found at https://github.com/terop/ruuvitag-sensor/commit/757b441cb7f6e7b0edbc48e87552ac8b100a2ae2. @ttu please take a look in case I missed something and if something should be change or improved.

terop avatar Feb 19 '24 18:02 terop

Thanks, commit looks good. I will leave comments if something comes to mind that is missing.

I was thinking that we should also drop support for 3.8 with this release. Its end of life is in October 2024, so by the time of the release, it won't be that far away. Based on the PyPI stats, it is not very widely used.

ttu avatar Feb 24 '24 07:02 ttu

So is the plan to wait for October to make the release or also remove 3.8 support before official support ends (and not wait for October)?

terop avatar Feb 24 '24 11:02 terop

There is no need to wait for the official support to end. Based on current pypistats, most installations are from Python 3.10 and above.

There will be a final release for v2 with the fixes that have not yet been released, and after that, we can begin preparations for the v3 release.

ttu avatar Feb 26 '24 17:02 ttu

Okay. I could then add another commit for the removal of Python 3.8.

terop avatar Feb 26 '24 18:02 terop

I rebased my branch from master and now it contains the following commits. Python 3.7 support removal: https://github.com/terop/ruuvitag-sensor/commit/b3658eb12266f34cb872e840d22388c033af4d38 Python 3.8 support removal: https://github.com/terop/ruuvitag-sensor/commit/0c948402893b046ffa741aeb7d82528fa3ac7c6a

terop avatar Feb 27 '24 16:02 terop

@ttu Could you kindly check the above commits?

terop avatar Mar 11 '24 18:03 terop

@terop sorry again for the delay. I think those commits already had pretty much all required changes. I found few mentions about default adapters that should be changed to Bleak, but after that I think those are good 👍

ttu avatar Apr 04 '24 18:04 ttu

Thanks for the comments @ttu. I fixed them as best I could and rebased the branch so now the commits are as follows: Python 3.7 support removal: https://github.com/terop/ruuvitag-sensor/commit/133ee503f61caaff79c8c50ac29648df39ee4750 Python 3.8 support removal: https://github.com/terop/ruuvitag-sensor/commit/ec28465cdabd14ce48a920a5bc56d1037c0e8aeb

terop avatar Apr 05 '24 08:04 terop

@terop sorry for the delay again. I finally had some time to get back to this.

I created two PRs; selecting default adapter and updated verification script. Could you create a PR for dropping Python 3.7 & 3.8 support?

I will still go through the functionality and test this with Linux to make sure we are not missing anything.

ttu avatar Jul 19 '24 07:07 ttu

@ttu Sure and sorry for the delay.

Please find a PR to drop Python 3.7 and 3.8 at https://github.com/ttu/ruuvitag-sensor/pull/251.

terop avatar Jul 23 '24 13:07 terop