json-flatfile-datastore icon indicating copy to clipboard operation
json-flatfile-datastore copied to clipboard

Published 20 hours ago • verified publisher icon ttu

Replace Newtonsoft.Json with System.Text.Json

Open PSanilP opened this issue 1 year ago • 3 comments

Any plans to move the library to native system.text.Json from Newtonsoft? It is an unnecessary dependency and going forward likely to be deprecated

PSanilP avatar Jun 20 '23 11:06 PSanilP

Hi! Currently there are no active plans to move away from Newtonsoft. We tried it some years ago, but there was some issues. Unfortunately we do not have any notes about issues we encountered.

We can definitely try this again 👍

edit: I added the link to the branch with System.Text.Json test code. If anyone has time to continue to work on it, just let me know. https://github.com/ttu/json-flatfile-datastore/compare/newtonsoft-to-system-text-json

ttu avatar Jun 23 '23 06:06 ttu

Hi! Currently there are no active plans to move away from Newtonsoft. We tried it some years ago, but there was some issues. Unfortunately we do not have any notes about issues we encountered.

We can definitely try this again 👍

Newtonsoft has problems with AOT compilation which seems like it will not be resolved: https://github.com/JamesNK/Newtonsoft.Json/issues/2732

SpicyBagpipes avatar Sep 14 '23 16:09 SpicyBagpipes