select2-bootstrap4-theme
select2-bootstrap4-theme copied to clipboard
ttskch
Updated toolchain, impoved multiselects and compatibility to select2 4.1
@weberhofer Thanks for your contribution! I updated toolchain on https://github.com/ttskch/select2-bootstrap4-theme/commit/993dea8b7fd0f755202f26afc066f94ffb8abb7a . And I cannot merge this PR to master branch because it breaks BC for users of select2 4.0. I will create a new branch to support select2 4.1. Please wait a moment. Thanks.
Hi @ttskch
Select 2 4.1 is now in RC. Most of the things already seems to work, if you create a branch I can help to check the missing ones
This branch contains an opinionated reimplementation of this theme working with Select2 4.1 RC0
I've used Bootstrap 4's custom-select to improve uniformity
I've tested on:
- latest Safari macOS 10.15
- latest Chrome macOS 10.15
- latest Firefox macOS 10.15
- latest Chrome on Windows 10
- latest Firefox on Windows 10
- latest Edge on Windows 10
- IE11 on Windows 10
I can't test on IE 10
@tagliala I have tested your reimplementation. I like it, but there seems to be a bug with an empty multiselect. Have a look at the following screenshot:
@NordicAT thanks. I've opened a new PR at #67
I like it, but there seems to be a bug with an empty multiselect.
I've added some extra fields to the demo for testing purposes. Any chance to share the original HTML so I can reproduce?
@NordicAT nope. Tested on windows chrome / firefox / edge / ie11
Can we continue at #67? we are off topic here