select2-bootstrap4-theme icon indicating copy to clipboard operation
select2-bootstrap4-theme copied to clipboard

[Suggestion] add a variables file, allow modifying the variables used in the scss files

Open WilliamStam opened this issue 5 years ago • 2 comments

im not a fan of the forcing of using secondary for many of the label colours etc. wouldnt it be better if you included a _variables.scss file similar to how bootstrap does it with !default? that way we can override the defaults with say $select2-theme-bootstrap4-secondary: $gray;

$select2-theme-bootstrap4-input-bg: $input-bg !default;
$select2-theme-bootstrap4-input-border-radius: $input-border-radius !default;
$select2-theme-bootstrap4-input-box-shadow: $input-box-shadow !default;
$select2-theme-bootstrap4-input-transition: $input-transition !default;
$select2-theme-bootstrap4-input-focus-border-color: $input-focus-border-color !default;
$select2-theme-bootstrap4-input-focus-box-shadow: $input-focus-box-shadow !default;
$select2-theme-bootstrap4-input-disabled-bg: $input-disabled-bg !default;


$select2-theme-bootstrap4-secondary: $secondary !default;

should be as easy as finding $ and then just prefixing them with a prefix and setting up a _variables.scss file

WilliamStam avatar May 27 '20 07:05 WilliamStam

Totally in favor of this approach

rodrigo-arias avatar Nov 04 '20 14:11 rodrigo-arias

I would like to do this in #67

tagliala avatar Mar 03 '21 14:03 tagliala