MouseTooltipTranslator icon indicating copy to clipboard operation
MouseTooltipTranslator copied to clipboard

Translation to Arabic missing

Open neoOpus opened this issue 9 months ago • 6 comments

A few days ago, I completed the Arabic translation and made a commit. However, when I tried to test it just now, I couldn't find any evidence of it. I must have made a mistake, but I distinctly recall making a commit and leaving a note to test the RTL before submitting a PR... Do you have any idea of what happened? As it is a bit tricky and took me a couple of hours to get it right...

neoOpus avatar Sep 22 '23 22:09 neoOpus

I think there may be conflict between commits I recently change all locale 12 line 'tts when' to 'voice when'

I find the commits but no pull request https://github.com/neoOpus/MouseTooltipTranslator/commit/056352913bdebfdb5b4ae4a8f4ba5075f4716203 when i tested on my computer, it shows arabic setting, but not sure on rtl (because i am not rtl user) Our style framework may support rtl, https://vuetifyjs.com/en/features/internationalization/

If you want to change locale language You need to change browser language , go chrome://settings/languages, make arabic as top priority and change display language relaunch browser

ttop32 avatar Sep 22 '23 23:09 ttop32

Oh, that's amazing! I will take care of performing the upgrade, then I will submit a PR. Thank you for the instructions. :)

neoOpus avatar Sep 23 '23 01:09 neoOpus

Daniel,

I did the testing and the translation shows somehow fine, but the text must be aligned to the right

https://www.w3.org/TR/css-writing-modes-4/#direction

I'm unsure where to make changes, but it would be helpful if you could assist me with the workflow setup.

Currently, I have copied the extension folder and replaced the JSON file, loading it locally instead of from the repository clone. Although I possess technical skills, I am not a programmer myself. I would like guidance on which part of the source code to modify in order to ensure proper functionality. After making the necessary edits, I would like to test it without having to swap files. This method is quick, and I may continue using it for now. However, I am interested in working further on this project if you don't mind. I plan to focus on translations and potentially some source code adjustments. I also have suggestions for reducing the extension size, which currently stands at around 10MB. Lastly, it would be wonderful if I could learn something from you during this process.

Thank you again for being supportive, I really appreciate.

neoOpus avatar Sep 23 '23 02:09 neoOpus

I did some modifications via the DevTool and the last two items that's how it should look like

image

It takes some changes like v-locale--is-rtl instead of v-locale--is-ltr I also modified this

<div class="v-window__container" style="
    direction: rtl;
">

<div class="v-field v-field--active v-field--appended v-field--dirty v-field--variant-underlined v-theme--light v-locale--is-rtl" role="button" aria-haspopup="menu" aria-expanded="false" aria-owns="v-menu-43" style="">

Tab text did not translate, but I will test for French first before reporting this… There are also some missing elements in the JSON to translate some of the other elements. If it works for you, we can go through them one by one.

neoOpus avatar Sep 23 '23 03:09 neoOpus

I changed vuetify to force rtl based on user browser lang https://github.com/ttop32/MouseTooltipTranslator/commit/7b0dcece98101e20d08de5e8a4f8e366ccb6ef6f you can build with following instruction https://github.com/ttop32/MouseTooltipTranslator#build-yourself-to-install

Currently, change locale may time consume which is based on chrome extension i18 api when file change , It need to reload every time and open popup manually There is not much different process on "swap file" and "build from watch" I will gonna find any easy locale update service for two track locale usage

Currently used webpack-ext-reloader only applied on contentScript and background script If file changed, it automaticlly reload page

ttop32 avatar Sep 23 '23 03:09 ttop32

maybe this service https://tolgee.io/ (Free for opensource)

neoOpus avatar Sep 23 '23 12:09 neoOpus