kaliiiiiiiiiii comments

Results 145 comments of


                                            kaliiiiiiiiiii

[Feature request] support for firefox

This mainly targets chromium based browsers, not firefox

cdp_socket.socket self._ws has no attribute 'open'

Relevant code here https://github.com/kaliiiiiiiiii/CDP-Socket/blob/4813479d7b856c4a609aa19e6fea80ed9d425445/src/cdp_socket/socket.py#L207 https://github.com/kaliiiiiiiiii/CDP-Socket/blob/4813479d7b856c4a609aa19e6fea80ed9d425445/src/cdp_socket/socket.py#L54 https://github.com/kaliiiiiiiiii/CDP-Socket/blob/4813479d7b856c4a609aa19e6fea80ed9d425445/src/cdp_socket/socket.py#L29

cdp_socket.socket self._ws has no attribute 'open'

Couldn't find where this has changed, but guess it should be adapted to https://github.com/python-websockets/websockets/blob/59d4dcf779fe7d2b0302083b072d8b03adce2f61/src/websockets/sync/connection.py#L144

Fix cdp_socket.socket self._ws has no attribute 'open' in self.close()

Thanks!

cdp_socket.exceptions.CDPError: {'code': -32600, 'message': 'Duplicate id in protocol request'}

Thanks!