chinese-support-addon icon indicating copy to clipboard operation
chinese-support-addon copied to clipboard

Incorrect colors on Hanzi based on compound pinyin

Open tanzoniteblack opened this issue 9 years ago • 1 comments

Description

When doing bulk "Fill incomplete readings and colors" of an expression like "老师是中国人" when the Pinyin field is already filled to "Lǎo shī shì Zhōng guórén." will cause the Pinyin field to be correctly annotated with colors, but the resulting Color field, will have incorrect tone markings.

If I then open the card and click on the Pinyin text field for editing and then click out of it, it automatically changes the Pinyin from "Lǎo shī shì Zhōng guórén." to "Lǎo shī shì Zhōng guó rén." (note exactly the same tone reading, just puts a space between the two syllables of the last word) and fixes the Color field as well.

Possible fix

Apply whatever function automatically cleans up inputted pinyin in the editor to pinyin that is found during the bulk "Fill incomplete readings and colors"

Screen shots

Pre-selecting text box in editor, card view

Pre-selecting text box in editor, editor view

After automatic changes that occurred to pinyin after visiting that field in the editor:

Post-selecting text box in editor, editor view

Post-selecting text box in editor, card view

tanzoniteblack avatar Jun 03 '15 16:06 tanzoniteblack

The fix I proposed seems to be the most straightforward and easiest, but it might also be worth looking into why the colors are being done differently between the Pinyin and Color fields in general?

tanzoniteblack avatar Jun 03 '15 16:06 tanzoniteblack