Cascade icon indicating copy to clipboard operation
Cascade copied to clipboard

Improve qmake OS detection on Linux

Open ttddee opened this issue 3 years ago • 2 comments

Right now qmake is only checking if we are on Windows or Linux. Since different dependencies are available on different Linux flavors, checking for the distribution we could avoid compiling unnecessary packages.

To check the distro in qmake something like this could work:

ARCH = $$system(cat /proc/version | grep -o Arch) 
UBUNTU = $$system(cat /proc/version | grep -o Ubuntu) 

contains( ARCH, Arch): 
{     
   do stuff
} 
contains( UBUNTU, Ubuntu): 
{     
   do other stuff
}

ttddee avatar May 14 '22 08:05 ttddee

Assign me

Yaraslaut avatar May 14 '22 09:05 Yaraslaut

I have added a check to the pro file to detect if we are on Ubuntu 18 LTS. Needed that for building the AppImages in Github Actions. That's how we could do it for other distros.

ttddee avatar May 27 '22 18:05 ttddee