gohbase icon indicating copy to clipboard operation
gohbase copied to clipboard

RPC objects should not embed a Context

Open tsuna opened this issue 3 years ago • 0 comments

Not only is it a bad practice to store the Context in a struct, but it actually led to a race condition being introduced when we added tracing (being fixed by PR #173). We should pass the Context along with the RPC, and when we derive a new context due to tracing we just pass along the derived context.

tsuna avatar Nov 18 '21 11:11 tsuna