Benjamin Roberts

Results 30 comments of Benjamin Roberts

@arkodg @euanh @cpuguy83 @theJeztah any unresolved issues in the PR as stands?

remediating PR is linked, any update on if this can be fixed and merged?

awesome - I can add a test like that but since the underlying logic relied on the same expandAlias logic I ommited it for now. do you want me to...

I've added the changelog - just noting though that there's a merge conflict between this and #767 so #767 would need to be merged first, then I can make the...

just to note that there's a small test break I'll need to push a change to depending on which order this and #763 get merged (if either is accepted

np will have a crack tomorrow - just noticed my local linting is broken too so will address both

haha all good, fwiw just about to push a fix for the linting issues but not the unit test as the point where tags is applied is in `protocol_common.go` as...