Thomas Stuefe
Thomas Stuefe
> Right, the refactoring to remove the `friend` declaration has completely fumbled the code. I'll probably force a revert on this to the state before that or do a git...
> Hi @tstuefe, > > Cleaned up Treap significantly, it looks way better now! Thanks for the ideas. Good. Will try to take a look on Thursday or Friday.
I will take a closer look later today, and also clean out some of my obsolete comments. GH interface is really not made for complex patches.
I disagree with this change. This should be discussed more broadly before trying to get a PR in. The associated JEP has been closed by Mark. Just a "oh well,...
@kimbarrett > P0035R4: Dynamic memory allocation for over-aligned data Do we really need this? I ask because, in the end, this will result in something like `posix_memalign` to be called,...
@lgxbslgx Okay, I moved the code around. Would appreciate for this PR to be done quickly, since there are follow up PRs and its really not that complex.
> I just provided some thoughts or suggestions based on my understanding. If my understanding is not right or low, please ignore it. Thanks again for your guidance. No problem....
friendly ping @jcking maybe?
> Hi, > > It seems like we only disable code which is relevant for debug build diagnostics, tests, or code otherwise used for debugging (`print_location`). Considering this, and ASAN's...