Thomas Stuefe

> > Good! But why make this conditional with a switch? Who would not want to have better error information? > > Because I want to be able to test...

We may squeeze out a bit more performance for the +AltGCForwarding case, eliminate one ref hop, by inlining the bases table into the SlidingForwarding object. Let the table follow the...

We are working on this. Pity I did not see this before. https://bugs.openjdk.org/browse/JDK-8294677 Sorry for the inconvenience.

> It's still there with OpenJDK 20 (from the extra/jdk-openjdk 20.0.2.u9-3 package on Arch Linux). > I fixed it for 21 onwards, and downported it to JDK 17. JDK 20...

Since this is not a clean backport, which part of it is not clean?

> I verified that the patch applies cleanly to jdk8u-dev master. I'm confused. The original patch https://hg.openjdk.org/jdk10/master/rev/723486922bfe touches ZipFile.java, not zip_util.c. How is this a clean apply? AFAICS this patch...

> Isn't this already fixed by #18753? > Yes, it would be good to try the changes in pull/18753 first. I still like @SoniaZaldana 's variant better. AFAIU, in the...

> > This may be food for another RFE, to keep this patch minimal. But a good solution, to me, would be like this: > > > > * have...

> > This mostly looks good. I'm just puzzled CHECK_EXCEPTION_NULL_FAIL. The JNI functions GetStaticMethodID, GetMethodID and NewObject return NULL with a pending exception when they fail. So I would expect...

Looks good. Ship it!