Thomas Stuefe

> Okay so we currently have `parse_integer` that calls `parse_integer_impl` to do the raw numeric parsing, then applies the modifiers conversions itself. I don't see why that structure needs to...

parse_memory_size renamed back to parse_integer as David requested.

@stefank @dholmes-ora @jdksjolen is the new version acceptable?

Thanks Johan. I'll wait for @stefank a bit more, but will commit later today since I'm having vacation coming up.

> > is the new version acceptable? > > I would have preferred if the parsing code were not placed in a .hpp file, and would have placed it in...

> > > is the new version acceptable? > > > > > > I would have preferred if the parsing code were not placed in a .hpp file, and...

Hi @stefank, sorry, I was gone for vacation and did not want to rush this before leaving. > > > > > is the new version acceptable? > > >...

/integrate

What you *could* do and what would be helpful is a very primitive gtest that tests that files opened with os::open are correctly tagged with FD_CLOEXEC.

I like this change. I am pretty sure not many know about this feature at all, we don't have that many knowledgeable Windows developers. If the methods are equivalent, I...