Thomas Strömberg
Thomas Strömberg
Can someone identify which line in boots is responsible for the fetching that is missing retry? It would help the person who might want to take this issue on.
If it helps, I've had good luck with using this library for exponential backoff+jitter, and have seen it used elsewhere in Tinkerbell (tink?): https://pkg.go.dev/github.com/cenkalti/backoff/v4
This sounds like a perfect good first issue. Feel free to send over a PR and I'll review it!
As far as I'm aware, no. We do have some big ideas in this space that we would like to explore in the future.
possibly related: #92
TIL that Go's JSON encoder is able to generate non-compliant JSON :(
> Wouldn't it be possible for us to change the FileReport struct to use an array of Behavior instead of a map[string]Behavior ? Sure - I'm open to that. PR's...
My first heap profile didn't yield anything interesting: ``` (pprof) top Showing nodes accounting for 8919.45kB, 100% of 8919.45kB total Showing top 10 nodes out of 38 flat flat% sum%...
 This 100MB sample looks a little more interesting: ``` Showing nodes accounting for 96.79MB, 100% of 96.79MB total Showing top 10 nodes out of 43 flat flat% sum% cum...
I'm making some progress in shaving down memory usage using pointers for larger structures, but I'm unconvinced that it will be enough to avoid OOM's.