u2f icon indicating copy to clipboard operation
u2f copied to clipboard

add indirection for the current time to facilitate testing

Open crewjam opened this issue 8 years ago • 1 comments

crewjam avatar Jun 21 '17 14:06 crewjam

Thanks for submitting the change. I think it's useful to be able to override the time for testing. However, I think the time function should be a field in the Config rather than a global variable. See tls.Config from the standard package crypto/tls (https://golang.org/pkg/crypto/tls/#Config). I know that currently Authenticate doesn't have a Config parameter but this could perhaps be added in a future breaking change to the API.

tstranex avatar May 05 '18 18:05 tstranex